-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tini install snippet #5408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to updating this, but I think it needs a bit more work (as I've noted in a few comments below).
Would you like to continue working on this, or would you prefer I take over from here?
6c823a5
to
c16a4dc
Compare
Thank you for the awesome detailed PR comments. I have updated based on the comments.
Updated snipped tested on:
|
c16a4dc
to
e5b78e5
Compare
@tianon would you mind reviewing when you have a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my suggestions.
18d1888
to
625149d
Compare
* Update tini to v0.18.0 (current latest release) * Improve gpg recv-keys as unreliable otherwise * Add comment about Alpine, Debian and Ubuntu now having tini packages * Use tini --version instead of tini --help which is not available in TINI_MINIMAL releases Snippet tested on: * Ubuntu 12.04 to 18.10 * Debian * Alpine * Centos 6+
Co-Authored-By: Firefishy <github@firefishy.com>
625149d
to
52d8511
Compare
@yosifkit Thank you for the review. I have merged and squashed all the recommended changes. |
tini --version
instead oftini --help
which is not available in TINI_MINIMAL releases.Snippet tested on: