Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OpenContainers image-spec labels to the currently updated tags. #8722

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Added OpenContainers image-spec labels to the currently updated tags. #8722

merged 2 commits into from
Sep 15, 2020

Conversation

Djelibeybi
Copy link
Contributor

Yet another packaging update.

Signed-off-by: Avi Miller avi.miller@oracle.com

Signed-off-by: Avi Miller <avi.miller@oracle.com>
@tianon
Copy link
Member

tianon commented Sep 14, 2020

See #3540 (comment), especially:

We don't actively recommend using labels. If an image maintainer wants to have labels, that is fine, but label names should adhere to the image spec: https://github.com/opencontainers/image-spec/blob/v1.0.1/annotations.md

(Speaking specifically of that bare maintainer label.)

@tianon
Copy link
Member

tianon commented Sep 14, 2020

(You likely intended to use org.opencontainers.image.authors instead?)

@Djelibeybi
Copy link
Contributor Author

Djelibeybi commented Sep 14, 2020

Well, no. I was maintaining (see what I did there?) the deprecated MAINTAINER directive and using org.opencontainers.image.vendor as the OpenContainers label that references the source organisation. I will switch maintainer to org.opencontainers.image.authors instead. Give me a few minutes to update the source repo.

@Djelibeybi
Copy link
Contributor Author

(Slightly more minutes are required to force push the images, though)

@github-actions
Copy link

Diff for 175e8ba:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 75c361c..ba794a8 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,9 +1,9 @@
 Maintainers: Oracle Linux Product Team <ol-ovm-info_ww@oracle.com> (@Oracle)
 GitRepo: https://github.com/oracle/container-images.git
 GitCommit: 01a15ec99c7470a3391c691509db1759b41eaf66
-amd64-GitCommit: 4094e84f7711e330510bcceae10aaec6d82f5ce7
+amd64-GitCommit: 283700269a887af4a45ba9bc614d8ad777cf702c
 amd64-GitFetch: refs/heads/dist-amd64
-arm64v8-GitCommit: 493b79e2372fbc371b19652580604c4603c81f50
+arm64v8-GitCommit: 154f9654e60f610896647ea9de43e383b6cc2850
 arm64v8-GitFetch: refs/heads/dist-arm64v8
 
 Tags: 6-slim
diff --git a/oraclelinux_6-slim/Dockerfile b/oraclelinux_6-slim/Dockerfile
index 0d4acdd..e59493f 100644
--- a/oraclelinux_6-slim/Dockerfile
+++ b/oraclelinux_6-slim/Dockerfile
@@ -1,5 +1,13 @@
 FROM scratch
-MAINTAINER Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>
+LABEL "org.opencontainers.image.authors"="Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>" \
+      "org.opencontainers.image.url"="https://github.com/oracle/container-images" \
+      "org.opencontainers.image.source"="https://github.com/oracle/container-images/tree/dist-amd64/6-slim" \
+      "org.opencontainers.image.vendor"="Oracle America, Inc" \
+      "org.opencontainers.image.title"="Oracle Linux 6 (slim)" \
+      "org.opencontainers.image.description"="Oracle Linux is an open-source \
+      operating system available under the GNU General Public License (GPLv2) and \
+      is suitable for both general purpose or Oracle workloads."
+
 ADD oraclelinux-6-slim-amd64-rootfs.tar.xz /
 
 # overwrite this with 'CMD []' in a dependent Dockerfile
diff --git a/oraclelinux_6/Dockerfile b/oraclelinux_6/Dockerfile
index 7336505..d487ee1 100644
--- a/oraclelinux_6/Dockerfile
+++ b/oraclelinux_6/Dockerfile
@@ -1,5 +1,13 @@
 FROM scratch
-MAINTAINER Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>
+LABEL "org.opencontainers.image.authors"="Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>" \
+      "org.opencontainers.image.url"="https://github.com/oracle/container-images" \
+      "org.opencontainers.image.source"="https://github.com/oracle/container-images/tree/dist-amd64/6.10" \
+      "org.opencontainers.image.vendor"="Oracle America, Inc" \
+      "org.opencontainers.image.title"="Oracle Linux 6" \
+      "org.opencontainers.image.description"="Oracle Linux is an open-source \
+      operating system available under the GNU General Public License (GPLv2) and \
+      is suitable for both general purpose or Oracle workloads."
+
 ADD oraclelinux-6.10-amd64-rootfs.tar.xz /
 
 # overwrite this with 'CMD []' in a dependent Dockerfile
diff --git a/oraclelinux_7-slim/Dockerfile b/oraclelinux_7-slim/Dockerfile
index 02bdd6b..1e2c6fc 100644
--- a/oraclelinux_7-slim/Dockerfile
+++ b/oraclelinux_7-slim/Dockerfile
@@ -1,5 +1,13 @@
 FROM scratch
-MAINTAINER Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>
+LABEL "org.opencontainers.image.authors"="Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>" \
+      "org.opencontainers.image.url"="https://github.com/oracle/container-images" \
+      "org.opencontainers.image.source"="https://github.com/oracle/container-images/tree/dist-amd64/7-slim" \
+      "org.opencontainers.image.vendor"="Oracle America, Inc" \
+      "org.opencontainers.image.title"="Oracle Linux 7 (slim)" \
+      "org.opencontainers.image.description"="Oracle Linux is an open-source \
+      operating system available under the GNU General Public License (GPLv2) and \
+      is suitable for both general purpose or Oracle workloads."
+
 ADD oraclelinux-7-slim-amd64-rootfs.tar.xz /
 
 # overwrite this with 'CMD []' in a dependent Dockerfile
diff --git a/oraclelinux_7/Dockerfile b/oraclelinux_7/Dockerfile
index fa05c58..fd963ec 100644
--- a/oraclelinux_7/Dockerfile
+++ b/oraclelinux_7/Dockerfile
@@ -1,5 +1,13 @@
 FROM scratch
-MAINTAINER Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>
+LABEL "org.opencontainers.image.authors"="Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>" \
+      "org.opencontainers.image.url"="https://github.com/oracle/container-images" \
+      "org.opencontainers.image.source"="https://github.com/oracle/container-images/tree/dist-amd64/7.8" \
+      "org.opencontainers.image.vendor"="Oracle America, Inc" \
+      "org.opencontainers.image.title"="Oracle Linux 7" \
+      "org.opencontainers.image.description"="Oracle Linux is an open-source \
+      operating system available under the GNU General Public License (GPLv2) and \
+      is suitable for both general purpose or Oracle workloads."
+
 ADD oraclelinux-7-amd64-rootfs.tar.xz /
 
 # overwrite this with 'CMD []' in a dependent Dockerfile
diff --git a/oraclelinux_8-slim/Dockerfile b/oraclelinux_8-slim/Dockerfile
index 205dc8b..99755db 100644
--- a/oraclelinux_8-slim/Dockerfile
+++ b/oraclelinux_8-slim/Dockerfile
@@ -1,5 +1,14 @@
 FROM scratch
-MAINTAINER Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>
+
+LABEL "org.opencontainers.image.authors"="Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>" \
+      "org.opencontainers.image.url"="https://github.com/oracle/container-images" \
+      "org.opencontainers.image.source"="https://github.com/oracle/container-images/tree/dist-amd64/8-slim" \
+      "org.opencontainers.image.vendor"="Oracle America, Inc" \
+      "org.opencontainers.image.title"="Oracle Linux 8 (slim)" \
+      "org.opencontainers.image.description"="Oracle Linux is an open-source \
+      operating system available under the GNU General Public License (GPLv2) and \
+      is suitable for both general purpose or Oracle workloads."
+
 ADD oraclelinux-8-slim-amd64-rootfs.tar.xz /
 
 # overwrite this with 'CMD []' in a dependent Dockerfile
diff --git a/oraclelinux_8/Dockerfile b/oraclelinux_8/Dockerfile
index 9cb16e6..d5039bc 100644
--- a/oraclelinux_8/Dockerfile
+++ b/oraclelinux_8/Dockerfile
@@ -1,5 +1,13 @@
 FROM scratch
-MAINTAINER Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>
+LABEL "org.opencontainers.image.authors"="Oracle Linux Product Team <ol-ovm-info_ww@oracle.com>" \
+      "org.opencontainers.image.url"="https://github.com/oracle/container-images" \
+      "org.opencontainers.image.source"="https://github.com/oracle/container-images/tree/dist-amd64/8.2" \
+      "org.opencontainers.image.vendor"="Oracle America, Inc" \
+      "org.opencontainers.image.title"="Oracle Linux 8" \
+      "org.opencontainers.image.description"="Oracle Linux is an open-source \
+      operating system available under the GNU General Public License (GPLv2) and \
+      is suitable for both general purpose or Oracle workloads."
+
 ADD oraclelinux-8-amd64-rootfs.tar.xz /
 
 # overwrite this with 'CMD []' in a dependent Dockerfile

@yosifkit yosifkit merged commit fbb2296 into docker-library:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants