-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for the release of websphre-liberty 20.0.0.10 #8854
Update for the release of websphre-liberty 20.0.0.10 #8854
Conversation
Diff for 5abaad9:TODO diff too large for GitHub comment!
See: http://github.com/docker-library/official-images/actions/runs/293639587 |
Can we please figure out some way to get those massive constantly-changing license files out of the build context so that the diffs here are reasonable? |
hi @tianon - is there a recommended path that other images have used for including licenses (which change with every release) in the images, without hitting this diff issue? |
The only other image that almost had a large licenses context was #8366 and they decided to download and verify them during the build to get them out of the build context. I guess my question is that if they are provided for open source license compliance of software included with the websphere liberty bundle, then why is it not just part of the |
I think the misunderstanding here is on me -- I was under the impression that this was more akin to a license enabling file (since it's been here but not in I fully agree with @yosifkit here -- if this is just the licenses of software contained in the image and is something you want to keep in this aggregated form, it should really be generated during the build of the image itself or else it will almost always suffer bitrot (as discussed in #8366 (comment) and the following comments). |
thanks guys - we are looking into updating this PR with a change that pulls in the licenses via URL. |
Release updates for websphere-liberty version 20.0.0.10