Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for the release of websphre-liberty 20.0.0.10 #8854

Closed

Conversation

crpotter
Copy link
Contributor

@crpotter crpotter commented Oct 7, 2020

Release updates for websphere-liberty version 20.0.0.10

@github-actions
Copy link

github-actions bot commented Oct 7, 2020

Diff for 5abaad9:
TODO diff too large for GitHub comment!
See: http://github.com/docker-library/official-images/actions/runs/293639587

@tianon
Copy link
Member

tianon commented Oct 7, 2020

Can we please figure out some way to get those massive constantly-changing license files out of the build context so that the diffs here are reasonable?

@arthurdm
Copy link
Contributor

hi @tianon - is there a recommended path that other images have used for including licenses (which change with every release) in the images, without hitting this diff issue?

@yosifkit
Copy link
Member

The only other image that almost had a large licenses context was #8366 and they decided to download and verify them during the build to get them out of the build context.

I guess my question is that if they are provided for open source license compliance of software included with the websphere liberty bundle, then why is it not just part of the wlp.zip? But if it is for software installed via apt, then surely /usr/share/doc/[package]/copyright is sufficient.

@tianon
Copy link
Member

tianon commented Oct 16, 2020

I think the misunderstanding here is on me -- I was under the impression that this was more akin to a license enabling file (since it's been here but not in open-liberty), not just a raw dump of open source license text.

I fully agree with @yosifkit here -- if this is just the licenses of software contained in the image and is something you want to keep in this aggregated form, it should really be generated during the build of the image itself or else it will almost always suffer bitrot (as discussed in #8366 (comment) and the following comments).

@arthurdm
Copy link
Contributor

thanks guys - we are looking into updating this PR with a change that pulls in the licenses via URL.

@arthurdm
Copy link
Contributor

I've created this PR into the WebSphere Liberty repo.

@crpotter - once that is merged, can you please update the GitCommit for this PR?

@arthurdm
Copy link
Contributor

hi @tianon / @yosifkit - I've created this new PR with the proposed license changes: #8930

Since @crpotter is away this week, can you please review that one, and close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants