Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Oracle Linux 6.7 #935

Merged
merged 1 commit into from
Jul 30, 2015
Merged

Adding Oracle Linux 6.7 #935

merged 1 commit into from
Jul 30, 2015

Conversation

Djelibeybi
Copy link
Contributor

Signed-off-by: Avi Miller avi.miller@gmail.com

Signed-off-by: Avi Miller <avi.miller@gmail.com>
@yosifkit
Copy link
Member

LGTM, Build test of #935; 27530d0 (oraclelinux):

$ url="https://raw.githubusercontent.com/docker-library/official-images/27530d01bcbd56655e66dd7728bfae824f9a6df4/library/oraclelinux"
$ bashbrew build "$url"
Fetching oraclelinux (git://github.com/oracle/docker.git) ...
Processing oraclelinux:latest ...
Processing oraclelinux:7 ...
Processing oraclelinux:7.1 ...
Processing oraclelinux:7.0 ...
Processing oraclelinux:6 ...
Processing oraclelinux:6.7 ...
Processing oraclelinux:6.6 ...
Processing oraclelinux:5 ...
Processing oraclelinux:5.11 ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing oraclelinux:latest
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-hard-coded-passwords' [3/3]...passed
testing oraclelinux:7.0
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-hard-coded-passwords' [3/3]...passed
testing oraclelinux:6
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-hard-coded-passwords' [3/3]...passed
testing oraclelinux:6.6
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-hard-coded-passwords' [3/3]...passed
testing oraclelinux:5
    'utc' [1/3]...passed
    'cve-2014--shellshock' [2/3]...passed
    'no-hard-coded-passwords' [3/3]...error: crypt password detected for 'root': '$1$xTbWrtZa$jAGz/RddHK2FpjpogKBkN0'
error: crypt password detected for 'oracle': '$1$xTbWrtZa$IU3Ttxl71dC2EPQZ5CERT0'
failed

There is at least one failure in the above build log.

@yosifkit
Copy link
Member

I don't see that we asked before, what are the reasons for keeping 7.0 and 6.6? The tags on the hub will stay regardless of what is here in the library file. The library file just controls when it is rebuilt and the "supported tags" list on the hub readme.

@Djelibeybi
Copy link
Contributor Author

@yosifkit we keep N-1 because there are times that we rebuild with critical security patches. Our customers hate upgrading, so the fact that we don't have tags going back to 6.0 should be celebrated.

@yosifkit
Copy link
Member

Start of relevant IRC conversation: https://botbot.me/freenode/docker-library/2015-07-30/?msg=46007907&page=1

tianon added a commit that referenced this pull request Jul 30, 2015
Adding Oracle Linux 6.7
@tianon tianon merged commit de0755e into docker-library:master Jul 30, 2015
@tianon
Copy link
Member

tianon commented Jul 30, 2015

Fair enough, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants