Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 8.0.0 (GA) #1090

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Update to 8.0.0 (GA) #1090

merged 1 commit into from
Nov 30, 2020

Conversation

tianon
Copy link
Member

@tianon tianon commented Nov 26, 2020

Happy 🦃 day from the PHP project, I guess? 🤷

This was referenced Nov 26, 2020
Copy link

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy 🐘 day

Copy link

@andypost andypost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to go!

@Yurunsoft

This comment has been minimized.

@dpfaffenbauer

This comment has been minimized.

@ghost

This comment has been minimized.

@eldadfux

This comment has been minimized.

@adhocore

This comment has been minimized.

@GrahamCampbell

This comment has been minimized.

@nusphere

This comment has been minimized.

@WyriHaximus

This comment has been minimized.

@Radiergummi

This comment has been minimized.

@tianon

This comment has been minimized.

@yosifkit yosifkit merged commit 6944008 into docker-library:master Nov 30, 2020
@yosifkit yosifkit deleted the 8-ga branch November 30, 2020 17:58
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 30, 2020
Changes:

- docker-library/php@6944008: Merge pull request docker-library/php#1090 from infosiftr/8-ga
- docker-library/php@8dfb458: Update to 8.0.0 (GA)
- docker-library/php@26e65d3: Update 7.3 to 7.3.25
- docker-library/php@0274f58: Update 7.4 to 7.4.13
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 30, 2020
Changes:

- docker-library/php@f936910: Merge pull request docker-library/php#1096 from infosiftr/pear-8.0
- docker-library/php@deb4a80: Keep "pecl update-channels" for 8.0 also
- docker-library/php@6944008: Merge pull request docker-library/php#1090 from infosiftr/8-ga
- docker-library/php@8dfb458: Update to 8.0.0 (GA)
- docker-library/php@26e65d3: Update 7.3 to 7.3.25
- docker-library/php@0274f58: Update 7.4 to 7.4.13
@FabianKoestring
Copy link

Is there a reason why amd/64 for 8.0.0-fpm-buster does not exists?

@panakour
Copy link

panakour commented Dec 1, 2020

@FabianKoestring the same also for 8.0-fpm-alpine on linux/amd64

@mruz
Copy link

mruz commented Dec 1, 2020

I'm getting "no matching manifest":

8.0.0-fpm-alpine3.12: Pulling from library/php
Service 'php' failed to build : no matching manifest for linux/amd64 in the manifest list entries

@ondrejmirtes
Copy link

I'm also getting an error:

#3 [internal] load metadata for docker.io/library/php:8-cli-alpine
#3 ERROR: no match for platform in manifest sha256:f185d3f285621848688a84df864516087bcb163fa600afd49ac2e735cbb667b7: not found

@WyriHaximus
Copy link

@FabianKoestring @panakour @ondrejmirtes It takes 8 to 12 hours to build the images for all architectures. As usual first come the ARM images before the AMD64 images start coming in, give it time and check again later today. Keep at eye on https://hub.docker.com/_/php/?tab=tags&page=1&ordering=last_updated&name=8.0.0- and make sure to expand the OS/ARCH column, it should show AMD64 in a few hours tops. (Note that the hours mentioned are per what I've been observing with previous builds of PHP Docker images.)

@rgeraads
Copy link

rgeraads commented Dec 1, 2020

It takes 8 to 12 hours to build the images for all architectures.

Out of curiosity: is that process visible somewhere?

@JoelLinn
Copy link

JoelLinn commented Dec 1, 2020

https://doi-janky.infosiftr.net/job/multiarch/job/amd64/job/php/ should pop up here. Log of latest build says it’s already pushed though🧐

@hollodotme
Copy link

Jep, it's there under https://hub.docker.com/r/amd64/php/tags?page=1&ordering=last_updated&name=8.0 but not yet under https://hub.docker.com/_/php/?tab=tags&page=1&ordering=last_updated&name=8.0

So docker pull amd64/php:8.0-fpm-alpine works just fine, but docker pull php:8.0-fpm-alpine doesn't yet.

@Carpenter0100
Copy link

amd64/php:8.0-fpm-alpine works fine. Thank you @hollodotme

@adhocore
Copy link

adhocore commented Dec 1, 2020

As usual first come the ARM images before the AMD64 images start coming in

would it be nice if we could prioritize linux/amd64 build before arm? (if possible)

@ondrejmirtes
Copy link

@adhocore That doesn't make sense, you just need to wait. Someone else might like that ARM comes first.

@WyriHaximus
Copy link

As usual first come the ARM images before the AMD64 images start coming in

would it be nice if we could prioritize linux/amd64 build before arm? (if possible)

shrug Normally it doesn't matter, and it's only lagging an hour or two behind. We're now all here because this is the first GA image of PHP 8 and we're super excited, you wouldn't notice unless you target patch versions in your Dockerfiles.

@adhocore
Copy link

adhocore commented Dec 1, 2020

just looking at the restlessness of all of us commenting and reacting here yearning for amd, maybe it is more ubiquitous compared to arm (at least for where php is made use of, not speaking statistically though) ?
even docker hub build seems to require linux/amd arch.

@dungahk
Copy link

dungahk commented Dec 1, 2020

I'm not a maintainer of the repository or anything like that but I would recommend people to raise a separate issue if they think amd64 should be built/pushed before arm as it is unrelated to this PR goal/subject.

@adhocore
Copy link

adhocore commented Dec 1, 2020

would it be nice if we could prioritize linux/amd64 build before arm? (if possible)

no. it would not. that's it. let's be done here.

@tianon
Copy link
Member Author

tianon commented Dec 1, 2020

We don't explicitly prioritize either architecture -- the build queues are fully independent of one another.

What actually happened here is that ARM managed to build and push faster than amd64 did, then we hit Docker's rate limits while trying to update the manifest lists for a while.

@tianon
Copy link
Member Author

tianon commented Dec 1, 2020

Also, all that has nothing to do with this repository; see https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what for an outline of the full build/push process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.