feat: generate libphp for the Alpine variant of ZTS builds #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 15, 2022
Changes: - docker-library/php@7894e03: Enable "embed" for the Alpine variant of ZTS builds (docker-library/php#1342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most popular use case for ZTS builds is to embed PHP in multithreaded programs such as FrankenPHP or NGINX Unit.
Unfortunately, generating libphp (which is necessary for this use case), is explicitly disabled for Alpine variants of the ZTS build.
This PR includes libphp in all ZTS builds (but not for the Alpine CLI variants, to keep the Alpine CLI image as small as possible).
Follows and fixes #1331 (comment).