Support sub-directories within docker-entrypoint-initdb.d

[lloydpowell88]

As it stands, the docker-entrypoint-initdb.d folder will only run the scripts from it's root.

I have a scenario where it would be extremely tidy for it to run all scripts from directories placed in the root also (recursively would be nice too but probably not required).

This makes the managing of a multi-version application deployed in multiple environments much more simplistic. It allows us to group our scripts by folders making them more understandable, readable and easier to avoid the alphabetical ordering of all the scripts (this could be done by the grouping folders).

I can make this change easily enough myself and more than happy to create a pull request to see if others would find it beneficial also.

What do you think team?

[lloydpowell88]

Pull Request if deemed appropriate - #606

[yosifkit]

Maybe we just recommend users mount a script and have it run other scripts in their folders.

Duplicate of #179

I think we are still hesitant to have such a possibly breaking change (even more now with the long precedent of the current behavior).

So the current script users need to create would be a copy lines 145-163 to get the same behavior.

postgres/docker-entrypoint.sh

Lines 145 to 163 in db45233

	for f in /docker-entrypoint-initdb.d/*; do
	case "$f" in
	*.sh)
	# https://github.com/docker-library/postgres/issues/450#issuecomment-393167936
	# https://github.com/docker-library/postgres/pull/452
	if [ -x "$f" ]; then
	echo "$0: running $f"
	"$f"
	else
	echo "$0: sourcing $f"
	. "$f"
	fi
	;;
	*.sql) echo "$0: running $f"; "${psql[@]}" -f "$f"; echo ;;
	*.sql.gz) echo "$0: running $f"; gunzip -c "$f" | "${psql[@]}"; echo ;;
	*) echo "$0: ignoring $f" ;;
	esac
	echo
	done

Hopefully #496 will be finished up soon and that should make it easier for the custom script. Once merged the script would be roughly one line of code.

#!/bin/bash
# script will need to not be executable (chmod -x) so that it gets sourced rather than executed
# that is the current behavior, but this function doesn't exist yet
docker_process_init_files /docker-entrypoint-initdb.d/*/*
# or something else to better control the order of script and sql processing

[lloydpowell88]

Thanks for the response @yosifkit .

That's a shame, although breaking changes shouldn't always be considered a blocker from releasing a new feature. Especially in a case like this where people probably shouldn't really be putting folders in if they don't expect them to be used.

Maybe it could be reconsidered for the next major version :-), then those updating will know the potential of breaking changes when updating.

Thanks for sending through the potential alternative, I'll keep my eye on that change making it's way through.

[yosifkit]

Closing since this is not something we want to add.

Since scripts initdb scripts can be sourced (#452) and everything in the script is functionalized (#496), a custom script in initdb can easily use the docker_process_init_files function to recurse as deeply as desired.

Related issues #179, #605, docker-library/mysql#192, docker-library/mysql#193