Update docker-entrypoint.sh #979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just made the same changes on my own and got adequate, expected and logical behavior. I don't mean to be rude, but I just want to ask: why aren't these changes still in the original postgres image? After all, this is a logical behavior - the user, if he needs it, adds his always-init.sh script to the always-init directory, if not needed - he does not add anything and postgres simply does nothing "always" (regardless of external conditions).
Only the duplication of the start/stop temp_server has been eliminated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just made the same changes on my own and got adequate, expected and logical behavior. I don't mean to be rude, but I just want to ask: why aren't these changes still in the original postgres image?
After all, this is a logical behavior - the user, if he needs it, adds his always-init.sh script to the always-init directory, if not needed - he does not add anything and postgres simply does nothing "always" (regardless of external conditions).