Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB_CHARSET and DB_COLLATE on docker-entrypoint.sh #327

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

luiscoms
Copy link
Contributor

It should fix #312

@tianon
Copy link
Member

tianon commented Aug 24, 2018

Given that these exist in the stock wp-config-sample.php (https://github.com/WordPress/WordPress/blob/5bbb3b38d96eb0aac29d3b368d541039a3b1fbb8/wp-config-sample.php#L34-L38), this LGTM.

@tianon tianon merged commit 4c9bb73 into docker-library:master Aug 24, 2018
@luiscoms luiscoms deleted the patch-2 branch August 24, 2018 19:05
tianon added a commit to infosiftr/stackbrew that referenced this pull request Aug 27, 2018
- `docker`: 18.09.0-ce-tp4
- `haproxy`: `SIGUSR1` (docker-library/haproxy#72)
- `julia`: update 1.0.0 Windows executable hashes (JuliaLang/julia#28840 (comment))
- `postgres`: escape user input for `psql` invocations (docker-library/postgres#489)
- `wordpress`: add `WORDPRESS_DB_CHARSET` and `WORDPRESS_DB_COLLATE` vars (docker-library/wordpress#327), WP-CLI 2.0.1
tianon added a commit to infosiftr/stackbrew that referenced this pull request Aug 27, 2018
- `docker`: 18.09.0-ce-tp4
- `haproxy`: `SIGUSR1` (docker-library/haproxy#72)
- `julia`: update 1.0.0 Windows executable hashes (JuliaLang/julia#28840 (comment))
- `postgres`: escape user input for `psql` invocations (docker-library/postgres#489)
- `wordpress`: add `WORDPRESS_DB_CHARSET` and `WORDPRESS_DB_COLLATE` vars (docker-library/wordpress#327), WP-CLI 2.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-entrypoint.sh does not consider DB_CHARSET & DB_COLLATE from environment variables
2 participants