-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove macOS specific code / support + shellcheck should avoid python, regardless of permissions #2466
Conversation
61ad30e
to
54e41d0
Compare
I'm sort of stuck running the tests and stuff locally... Per #2467, postfix won't install due to the builder container not having a full FQDN |
I made two unrelated to the PR, but blocker fix changes in this :
|
51caaf6
to
1ab8ea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But there are still some ${@:+$@}
left in setup.sh
and lint.sh
4d615e2
to
66cf4f3
Compare
Documentation preview for this PR is ready! 🎉 Built with commit: 45068ff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently on vacation in Madeira, therefore only had a quick look, but LGTM
Description
Supporting macOS is a nightmare. Users can run a headless linux VM, mount the docker-mailserver directory into it, and run make commands if they are on macOS.
Type of change
Checklist:
docs/
)