-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump docker/build-push-action from 3.3.0 to 4.0.0 #3066
chore(deps): Bump docker/build-push-action from 3.3.0 to 4.0.0 #3066
Conversation
Please check if this might be breaking anything :) I found nothing yet that would break our CI, but I could be missing something. I added the label |
It just appears to be about the "SLSA Provenance attestation" support being enabled by default into images when possible. Breaking change as some registries may not be compatible from what I could make of the Changelog. I think ours registries are unaffected though 👍 |
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3.3.0 to 4.0.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3.3.0...v4.0.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
c534f8b
to
d8a8ef9
Compare
I ran into problems with the new default of Building my images with |
Did you mean '
Agreed, but we should check first whether we can build with provenance=true. @casperklein can you check that in the fork of yours? |
That was a typo. Ive edited my post. The build was successful in both cases for me. My problem was related to using the image afterwords. Some docker cli commands are not yet ready to handle images with added provenance. |
Is that running with BuildKit The CLI has recently got improved support for manifest. Once Docker Engine We don't have any demand for the feature, so I'm fine opt-ing out. |
Then let's opt out :D @casperklein could you please adjust the PR accordingly?:) |
I assume we still want the bot to raise new PRs when minor releases are made? But until comfortable going ahead with it, we'll have to keep closing the PRs. Better than ignoring and forgetting about it though? 😅 |
I'd go ahead with the new version but opt out of the new feature - this way we can later opt-in and don't have to worry about always closing PRs @dependabot raises. So adjust the changes here and then merge it IMO. |
Oh right.. long day 😅 |
I checked the buildkit version, it's Details
|
Oh awesome, they released 23.0 this month 🎉 |
Bumps docker/build-push-action from 3.3.0 to 4.0.0.
Release notes
Sourced from docker/build-push-action's releases.
Commits
3b5e802
Merge pull request #784 from crazy-max/enable-provenance02d3266
update generated contentf403daf
revert disable provenance by default if not set1104d47
Merge pull request #781 from crazy-max/disable-provenance838bf90
update generated content337a09d
disable provenance by default if not setDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)