Merge pull request #51 from crazy-max/fix-docker-exporter

buildx: fix docker exporter check
docker · Feb 20, 2023 · 1383a2b · 1383a2b
2 parents d153cfa + 1acd6c2
commit 1383a2b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/__tests__/buildx/inputs.test.ts b/__tests__/buildx/inputs.test.ts
@@ -228,6 +228,8 @@ describe('hasDockerExporter', () => {
     [['type=docker', 'type=tar,dest=/tmp/image.tar'], true, undefined],
     [['"type=tar","dest=/tmp/image.tar"'], false, undefined],
     [['" type= local" , dest=./release-out'], false, undefined],
+    [['type=docker'], true, false],
+    [['type=docker'], true, true],
     [['.'], true, true],
   ])('given %p returns %p', async (exporters: Array<string>, expected: boolean, load: boolean | undefined) => {
     expect(Inputs.hasDockerExporter(exporters, load)).toEqual(expected);

diff --git a/src/buildx/inputs.ts b/src/buildx/inputs.ts
@@ -134,7 +134,7 @@ export class Inputs {
   }
 
   public static hasDockerExporter(exporters: string[], load?: boolean): boolean {
-    return load ?? Inputs.hasExporterType('docker', exporters);
+    return load || Inputs.hasExporterType('docker', exporters);
   }
 
   public static hasExporterType(name: string, exporters: string[]): boolean {