-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache: move gha cache save to post state #280
Conversation
c026dab
to
996c8de
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
|
||
const fixturesDir = path.join(__dirname, 'fixtures'); | ||
|
||
describe('cache', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for my own education - what does itg
in the filename cache.test.itg.ts
stand for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is using a dedicated jest config for integration tests
actions-toolkit/jest.config.itg.ts
Line 22 in cbcf885
testMatch: ['**/*.test.itg.ts'], |
this way we can run each them on dedicated runners on ci:
actions-toolkit/.github/workflows/test.yml
Lines 82 to 94 in cbcf885
test-itg: | |
runs-on: ${{ matrix.os }} | |
needs: | |
- prepare-itg | |
strategy: | |
fail-fast: false | |
matrix: | |
test: ${{ fromJson(needs.prepare-itg.outputs.matrix) }} | |
os: | |
- ubuntu-latest | |
#- macos-13 # https://github.com/docker/actions-toolkit/issues/279 | |
- macos-latest | |
- windows-latest |
https://github.com/docker/actions-toolkit/blob/main/jest.config.ts is for unit tests only.
follow-up #241
This moves github actions cache save handling in post step like it's currently done with official actions such as
actions/setup-go
.