Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to define behavior when empty parameters are passed #357

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

campbel
Copy link
Contributor

@campbel campbel commented Jun 11, 2024

Add a single test to define behavior when an empty string is passed to the input list.

For context, my team was trying to determine a proper default value to set in a re-packaged internal version of docker/build-push-action@v4's platform field. We wanted to make this configurable, but wanted to provide a valid default value that wouldn't change behavior as we previously didn't set this. Checking the source, led us here where we didn't find it included in the test spec. Adding this test should make the expected behavior well defined and allow folks to depend on it.

Signed-off-by: Chris Campbell <chris.campbell@dutchie.com>
@campbel campbel force-pushed the campbel/get-input-list-empty-test branch from 6a02a71 to 82d1000 Compare June 11, 2024 21:31
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit 1bf4b58 into docker:main Jun 11, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants