github(summary): add collapsible section for build inputs and bake def #377
+176
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
summary-collapsible
branch
3 times, most recently
from
13ad782
to
3172323
Compare
crazy-max
requested review from
tonistiigi,
sharonchang1,
dvdksn and
colinhemmings
crazy-max
force-pushed
the
summary-collapsible
branch
from
3172323
to
68623fe
Compare
|
What do you think about making section titles the 
I also noticed that we generate an H1 for every summary. An HTML document should never have more than one H1 so I think we should make them H2. |
crazy-max
force-pushed
the
summary-collapsible
branch
6 times, most recently
from
bf2bfaf
to
4471656
Compare
|
@dvdksn PR description updated based on your suggestion |
crazy-max
force-pushed
the
summary-collapsible
branch
5 times, most recently
from
649aadd
to
b9b815a
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
summary-collapsible
branch
from
b9b815a
to
e7017a2
Compare
tonistiigi
approved these changes
Jun 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #369
Based on https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections
Example here: https://github.com/docker/actions-toolkit/actions/runs/9599193396#summary-26472403316
cc @ruffsl @Pesa