Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github(summary): remove preview title and tidy download link #383

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jun 25, 2024

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title github(summary): remove preview title github(summary): remove preview title and tidy download link Jun 25, 2024
@crazy-max crazy-max marked this pull request as ready for review June 25, 2024 10:20
@colinhemmings
Copy link

Looks good. But the semicolon looks a bit odd. Why don't we just say (6KB and includes 1 build record)

@crazy-max
Copy link
Member Author

crazy-max commented Jun 25, 2024

Looks good. But the semicolon looks a bit odd. Why don't we just say (6KB and includes 1 build record)

semicolon was to link closely related independent clauses but dash seems to be a better alternative for readability while giving a slight emphasis on the additional information about the build record: (5.88 KB - includes 1 build record)

WDYT @dvdksn?

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@dvdksn
Copy link

dvdksn commented Jun 25, 2024

LGTM

@crazy-max crazy-max merged commit e600fe2 into docker:main Jun 26, 2024
38 checks passed
@crazy-max crazy-max deleted the summary-rm-preview-title branch June 26, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants