github(summary): update learn more link #384
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
| @@ -240,7 +240,7 @@ export class GitHub { | |||
| .addRaw(`For a detailed look at the build, download the following build record archive and import it into Docker Desktop's Builds view. `) | |||
| .addBreak() | |||
| .addRaw(`Build records include details such as timing, dependencies, results, logs, traces, and other information about a build. `) | |||
| .addRaw(addLink('Learn more', 'https://docs.docker.com/go/build-summary/')) | |||
| .addRaw(addLink('Learn more', 'https://www.docker.com/blog/new-beta-feature-deep-dive-into-github-actions-docker-builds-with-docker-desktop/?utm_source=github&utm_medium=actions')) | |||
There was a problem hiding this comment.
also sets utm_source and utm_medium
There was a problem hiding this comment.
Go idea to add the UTM components. Do you think we should still use a go path and handle the redirect?
@dvdksn, maybe we should distill this post down into some "Introductory Guide" for users not familiar with Builds View?
There was a problem hiding this comment.
Hmm yeah, why not? We could have that intro page in the manual section for builds, and link off to the full description in the Docker Desktop section.
There was a problem hiding this comment.
Do you think we should still use a go path and handle the redirect?
I don't think /go fits if we are using UTM parameters
There was a problem hiding this comment.
We have a few go-links with utm params, for example:
https://github.com/docker/docs/blob/main/data/redirects.yml#L694-L700
There was a problem hiding this comment.
We have a few
go-links with utm params, for example: https://github.com/docker/docs/blob/main/data/redirects.yml#L694-L700
How do we make sure the source/medium is right? For example if I open within my browser https://docs.docker.com/go/build-eap/ these are wrong as this does not come from Docker Desktop but directly from my browser. That's my concern.
There was a problem hiding this comment.
yeah, there is no guarantee that the link will be accessed only from the correct source, providing the correct utm.
updates learn more link to the docker blog post https://www.docker.com/blog/new-beta-feature-deep-dive-into-github-actions-docker-builds-with-docker-desktop/