buildx: convert vertex warnings to github annotations based on localstate #401
+272
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
build-warnings-localstate
branch
5 times, most recently
from
a956173
to
415ec12
Compare
crazy-max
changed the title
crazy-max
force-pushed
the
build-warnings-localstate
branch
from
415ec12
to
6b82c1b
Compare
crazy-max
commented
Jul 5, 2024
src/buildx/buildx.ts
Outdated
| continue; | ||
| } | ||
|
|
||
| if (ls.DockerfilePath == '-' || ls.DockerfilePath.endsWith('/-')) { |
There was a problem hiding this comment.
ls.DockerfilePath.endsWith('/-') is necessary for Buildx < 0.16.0 related to docker/buildx#2560
There was a problem hiding this comment.
made a proper fix in #403
crazy-max
force-pushed
the
build-warnings-localstate
branch
from
6b82c1b
to
02ec2ec
Compare
crazy-max
force-pushed
the
build-warnings-localstate
branch
3 times, most recently
from
65b7e9a
to
8efe5ce
Compare
crazy-max
force-pushed
the
build-warnings-localstate
branch
from
8efe5ce
to
93f0066
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
…tate Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
build-warnings-localstate
branch
from
93f0066
to
05e3bb5
Compare
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up
Implementation introduced in #365 would generate annotations for a specified dockerfile. We forgot cases when a dockerfile can be inline and therefore not part of the repository or also when using a git context that could build another repository. With these changes we make sure warnings are associated with a dockerfile in the working tree before being annotated.