Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker/install: Support rootless #485

Merged
merged 1 commit into from
Nov 7, 2024
Merged

docker/install: Support rootless #485

merged 1 commit into from
Nov 7, 2024

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented Nov 5, 2024 •
edited
Loading

Add support for running a rootless daemon. Currently only Linux host is supported.

@vvoland vvoland force-pushed the docker-install-rootless branch 7 times, most recently from 324f9c9 to bfd2263 Compare November 5, 2024 15:46
@crazy-max
Copy link
Member

https://github.com/docker/actions-toolkit/actions/runs/11687682100/job/32546382492?pr=485#step:10:198

  + echo rootlesskit needs to be installed
  rootlesskit needs to be installed
  + exit 1

Missing rootlesskit?

@vvoland vvoland force-pushed the docker-install-rootless branch from bfd2263 to f85f73e Compare November 5, 2024 15:51
@vvoland
Copy link
Contributor Author

vvoland commented Nov 5, 2024 •
edited
Loading

It lost the PATH when sudoing as a non-root user.
Anyway, I'm mostly abusing the draft PR to run the CI on the GHA runner, feel free to ignore for now 😅

@vvoland vvoland force-pushed the docker-install-rootless branch from f85f73e to 293c0ee Compare November 5, 2024 15:55
@crazy-max
Copy link
Member

It lost the PATH when sudoing as a non-root user.

Might need sudo -E

@vvoland vvoland force-pushed the docker-install-rootless branch 6 times, most recently from 409eeff to d7de9c8 Compare November 6, 2024 12:57
@vvoland vvoland marked this pull request as ready for review November 6, 2024 14:35
@vvoland vvoland changed the title [WIP] docker/install: Support rootless docker/install: Support rootless Nov 6, 2024
@vvoland
Copy link
Contributor Author

vvoland commented Nov 6, 2024

Ready for review @crazy-max

@vvoland vvoland mentioned this pull request Nov 6, 2024
Merged
@vvoland vvoland force-pushed the docker-install-rootless branch from 62577a5 to ce839e8 Compare November 6, 2024 16:32
@vvoland vvoland marked this pull request as draft November 6, 2024 16:43
@vvoland vvoland force-pushed the docker-install-rootless branch from b1a64ac to 2afeeaa Compare November 6, 2024 16:55
@vvoland
docker/install: Support rootless
2d2bc84 
Add support for running a rootless daemon. Currently only Linux host is
supported.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland force-pushed the docker-install-rootless branch from 2afeeaa to 2d2bc84 Compare November 6, 2024 17:02
@vvoland vvoland marked this pull request as ready for review November 6, 2024 17:07
crazy-max
crazy-max approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit 37b0f81 into docker:main Nov 7, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvoland @crazy-max