Add build parameters to docker app build command #697
Conversation
glours
force-pushed
the
add_build_arg_option
branch
6 times, most recently
from
6d3e088
to
52d1328
Compare
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
- Coverage 72.08% 71.85% -0.23%
==========================================
Files 62 56 -6
Lines 3496 2931 -565
==========================================
- Hits 2520 2106 -414
+ Misses 653 552 -101
+ Partials 323 273 -50
Continue to review full report at Codecov.
|
glours
force-pushed
the
add_build_arg_option
branch
from
52d1328
to
d946b87
Compare
|
@glours can you rebase? 🦁 |
|
Is it possible to add some information to the PR description? |
internal/commands/build/types.go
Outdated
| @@ -70,3 +76,30 @@ func transformBuildConfig(data interface{}) (interface{}, error) { | |||
| return data, errors.Errorf("invalid type %T for service build", value) | |||
| } | |||
| } | |||
|
|
|||
| func transformBuildArgsArray(array []string, sep string, allowNil bool) map[string]string { | |||
There was a problem hiding this comment.
Do we really need to pass the separator and allowNil as this method is called only once with fixed values?
Why not something like mapBuildArgs or buildArgsToMap? Something that exposes the intention in the method name, transform is not very clear.
|
@eunomie PR description updated, sorry for that |
glours
force-pushed
the
add_build_arg_option
branch
from
d946b87
to
df545da
Compare
internal/commands/build/types.go
Outdated
| for _, value := range array { | ||
| parts := strings.SplitN(value, "=", 2) | ||
| key := parts[0] | ||
| switch { |
There was a problem hiding this comment.
Why a switch here and not a
if len(parts) == 1 {
result[key] = ""
} else {
result[key] = parts[1]
}that does the same thing but maybe more easy to read
There was a problem hiding this comment.
I'm fine with switch 😅
else is bad, mkay?
There was a problem hiding this comment.
If else is bad you can write:
result[key] = ""
if len(parts) != 1 {
result[key] = parts[1]
}
glours
force-pushed
the
add_build_arg_option
branch
from
df545da
to
e3c893d
Compare
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
glours
force-pushed
the
add_build_arg_option
branch
from
e3c893d
to
1ee6dd3
Compare
- What I did
Pass
--build-argparameter to buildx to build service images- How I did it
Add a
--build-argflagCheck a build arg isn't defined twice
Replace build arg defined in compose file & pass the list of args to buildx for generating service images
- How to verify it
run
docker --debug app build e2e/testdata/build/ --build-arg REPLACE_BY_BUILD_ARG=plopcheck you see the following trace in the debug output in the
workersection of thecom.docker.app.invocation-imageFind the
workerimage sha256 & then do adocker image inspectwith the given sha & make sure to haverun
docker app build e2e/testdata/build/single.dockerapp --build-arg REPLACE_BY_BUILD_ARG=plop --build-arg REPLACE_BY_BUILD_ARGand check you have the following error message'--build-arg REPLACE_BY_BUILD_ARG' is defined twice- A picture of a cute animal (not mandatory but encouraged)
