Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Make image inspect more in line with other tables #701

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Oct 18, 2019

- What I did

Changed the output of docker app image inspect to be more in line with other tables the cli has:

version: 0.1.0
name: voting-app
description: Dogs or cats?
maintainers:
- name: user
  email: user@email.com


SERVICE REPLICAS PORTS IMAGE
db      1        5432  postgres:9.4
redis   1        6379  redis:alpine
result  1        5001  dockersamples/examplevotingapp_result:before
vote    2        5000  dockersamples/examplevotingapp_vote:before
worker  1              dockersamples/examplevotingapp_worker

PARAMETER     VALUE
result.port   5001
vote.port     5000
vote.replicas 2

- A picture of a cute animal (not mandatory but encouraged)
image

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@@ -146,25 +146,11 @@ func printSection(out io.Writer, len int, printer func(io.Writer), headers ...st
}
fmt.Fprintln(out)
w := tabwriter.NewWriter(out, 0, 0, 1, ' ', 0)
var plural string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buh-bye 👋

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #701 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #701     +/-   ##
=========================================
- Coverage   71.43%   71.34%   -0.1%     
=========================================
  Files          59       59             
  Lines        2955     2945     -10     
=========================================
- Hits         2111     2101     -10     
  Misses        569      569             
  Partials      275      275
Impacted Files Coverage Δ
internal/inspect/inspect.go 86.88% <100%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab69992...17f66a5. Read the comment docs.

@rumpl rumpl merged commit 0c6905a into docker:master Oct 18, 2019
@rumpl rumpl deleted the last-image-inspect-version branch October 18, 2019 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants