Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Docker app run runs only references #702

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

rumpl
Copy link
Member

@rumpl rumpl commented Oct 18, 2019

- What I did

A new flag --cnab-bundle-json is added for running a CNAB bundle directly. Otherwise, a built app is ran.

- How to verify it

Run docker app run --cnab-bundle-json e2e/testdata/cnab-without-status/bundle.json.

- Description for the changelog
You can run a CNAB bundle with docker app run --cnab-bundle-json BUNDLE

- A picture of a cute animal (not mandatory but encouraged)
image

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #702 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #702   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          59       59           
  Lines        3042     3042           
=======================================
  Hits         2212     2212           
  Misses        556      556           
  Partials      274      274

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c6905a...4158c4b. Read the comment docs.

internal/commands/run.go Outdated Show resolved Hide resolved
internal/cnab/cnab.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jcsirot jcsirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/cnab/cnab.go Outdated Show resolved Hide resolved
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image argument and cnab-bundle-json flag are mutually exclusive.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A new flag `--cnab-bundle-json` is added for running a CNAB bundle
directly. Otherwise, a built app is ran.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@silvin-lubecki silvin-lubecki merged commit 277a41d into docker:master Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants