This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
If no image tag set use image content-digest #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also make the compose spec compliant with docker stack deploy, which require service.image attribute set Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 72.11% 71.29% -0.83%
==========================================
Files 59 59
Lines 3016 2947 -69
==========================================
- Hits 2175 2101 -74
- Misses 560 570 +10
+ Partials 281 276 -5
Continue to review full report at Codecov.
|
rumpl
approved these changes
Oct 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Support running a docker app build without service image tags
https://docker.atlassian.net/browse/APP-271
- How I did it
Use the content-digest of the image, which docker engine can resolve if already pulled
- How to verify it
Use a compose file without explicit image tag
docker app build && docker app run
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)