This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Validate parameters against the actual compose file #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
APP-117
branch
2 times, most recently
from
064895e
to
507e365
Compare
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
======================================
Coverage 71.2% 71.2%
======================================
Files 59 59
Lines 3011 3011
======================================
Hits 2144 2144
Misses 583 583
Partials 284 284Continue to review full report at Codecov.
|
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
| "testing" | ||
|
|
||
| "gotest.tools/assert" | ||
|
|
There was a problem hiding this comment.
import order looks wrong 🤣
eunomie
approved these changes
Oct 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
add a validation step to ensure parameters are actually used by compose file
- How I did it
Reused ExtractVariables from
initand compare with parameters- How to verify it
validate a dockerapp with unecessart parameters
- Description for the changelog
docker app validate do check parameters are in actual use by compose file
- A picture of a cute animal (not mandatory but encouraged)
