This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Feat run labels #715
Merged
Feat run labels #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
force-pushed
the
feat-run-labels
branch
from
62abf81
to
1a852e0
Compare
rumpl
force-pushed
the
feat-run-labels
branch
from
1a852e0
to
8ce977e
Compare
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
========================================
- Coverage 71.49% 71.4% -0.1%
========================================
Files 59 59
Lines 3280 3175 -105
========================================
- Hits 2345 2267 -78
+ Misses 605 602 -3
+ Partials 330 306 -24
Continue to review full report at Codecov.
|
jcsirot
reviewed
Oct 29, 2019
jcsirot
reviewed
Oct 29, 2019
This will add the given labels to all the containers inside the application (except for the invocation image). The labels are passed over by file, this is to be able to easely add new parameters in the future and limit the explosion of parameters we have in our bundle Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feat-run-labels
branch
from
8ce977e
to
5311fa0
Compare
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feat-run-labels
branch
from
5311fa0
to
248d5ab
Compare
jcsirot
reviewed
Oct 31, 2019
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added
--labelflag when running an applicationThis will add the given labels to all the containers inside the
application (except for the invocation image). The labels are passed
over by file, this is to be able to easely add new parameters in the
future and limit the explosion of parameters we have in our bundle
- Description for the changelog
Add labels to service containers with the
--labelflag onrun.- A picture of a cute animal (not mandatory but encouraged)
