This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Fix handling short id in docker app commands #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
jcsirot
force-pushed
the
fix-handling-short-id
branch
from
604f178
to
2f13025
Compare
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
=======================================
Coverage 72.45% 72.45%
=======================================
Files 59 59
Lines 3438 3438
=======================================
Hits 2491 2491
Misses 612 612
Partials 335 335Continue to review full report at Codecov.
|
rumpl
reviewed
Oct 28, 2019
ndeloof
approved these changes
Oct 28, 2019
eunomie
reviewed
Oct 29, 2019
jcsirot
force-pushed
the
fix-handling-short-id
branch
4 times, most recently
from
015dc6d
to
7fa7cc7
Compare
| var ( | ||
| identifierRegexp = regexp.MustCompile(`^([a-f0-9]{64})$`) | ||
|
|
||
| shortIdentifierRegexp = regexp.MustCompile(`^([a-f0-9]{1,64})$`) |
There was a problem hiding this comment.
Only one character looks a little bit short, isn't it too widely open?
There was a problem hiding this comment.
It seems that docker image inspect x works if you have only 1 image whose id is starting with x
| if err != nil { | ||
| return nil, errors.Wrapf(err, "failed to read bundle %q", ref) | ||
| } | ||
|
|
||
| data, err := ioutil.ReadFile(filepath.Join(path, "bundle.json")) | ||
| bndl, err := b.fetchBundleJSON(filepath.Join(paths[0], "bundle.json")) |
There was a problem hiding this comment.
What happens to other paths here? Is it worth it returning all the paths if we only use the first (and I guess it has to be the id path?
jcsirot
force-pushed
the
fix-handling-short-id
branch
from
7fa7cc7
to
2878175
Compare
jcsirot
force-pushed
the
fix-handling-short-id
branch
from
2878175
to
606e6d3
Compare
chris-crone
approved these changes
Oct 30, 2019
jcsirot
force-pushed
the
fix-handling-short-id
branch
from
606e6d3
to
5ac6329
Compare
…le store. Now the bundle store scans the bundle directory and creates a map of existing bundle references. All subsequent operations on the bundle store are using this map as the reference for stored bundle. Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
jcsirot
force-pushed
the
fix-handling-short-id
branch
from
5ac6329
to
280f562
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This PR add the possibility to use short id in
docker appcommands (app image tag,app image remove,app run...)- How I did it
The bundle store interface now exposes a
LookUpfunction which convert a string (an id, short id, tagged or digested reference) into areference.Referenceobject if it exists in the store. A map ofIDto[]reference.Referenceis also maintained by the bundle store implementation.- How to verify it
Some unit tests and e2e tests have been added
- A picture of a cute animal (not mandatory but encouraged)