Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Move render command under image command #726

Merged
merged 2 commits into from
Nov 6, 2019

Conversation

jcsirot
Copy link
Contributor

@jcsirot jcsirot commented Nov 5, 2019

- What I did
Remove the render command and move it as new image subcommand.

- How I did it
Move render.go into image package.
Bundle parameters merging algorithm is invoked from some root commands and image render command. Therefore the bundle parameters merging had to be move to a dedicated package in order to avoid go package cycles.

- How to verify it

  • run docker app render myapp:mytag and ensure the command does not exist
  • run docker app image render myapp:mytag and verify the App is rendered

- A picture of a cute animal (not mandatory)

image

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6f5737a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #726   +/-   ##
=========================================
  Coverage          ?   71.42%           
=========================================
  Files             ?       59           
  Lines             ?     3178           
  Branches          ?        0           
=========================================
  Hits              ?     2270           
  Misses            ?      602           
  Partials          ?      306
Impacted Files Coverage Δ
internal/commands/root.go 74.72% <ø> (ø)
internal/commands/image/render.go 72.41% <100%> (ø)
internal/bundle/parameters.go 86.51% <100%> (ø)
internal/commands/update.go 58.18% <100%> (ø)
internal/commands/run.go 61.11% <100%> (ø)
internal/commands/image/command.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5737a...3c05dee. Read the comment docs.

… parameters merging into a specific package to avoid package cycles

Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
…command packages

Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit f141d47 into docker:master Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants