Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

APP-304 Update e2e tests using --folder flag #727

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

aiordache
Copy link
Contributor

@aiordache aiordache commented Nov 6, 2019

- What I did
Updated the e2e tests that were using the --folder flag

- How to verify it
The e2e TestRender/envvariables test should pass now.

- A picture of a cute animal (not mandatory)

image

Signed-off-by: Anca Iordache anca.iordache@docker.com

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "app-304_correct_app_build_help" git@github.com:aiordache/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Anca Iordache anca.iordache@docker.com
Copy link
Contributor

@zappy-shu zappy-shu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6f5737a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #727   +/-   ##
=========================================
  Coverage          ?   71.43%           
=========================================
  Files             ?       59           
  Lines             ?     3175           
  Branches          ?        0           
=========================================
  Hits              ?     2268           
  Misses            ?      601           
  Partials          ?      306

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5737a...7af854e. Read the comment docs.

@zappy-shu zappy-shu merged commit 9042ab2 into docker:master Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants