Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Download Docker CLI instead of building it #730

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

chris-crone
Copy link
Member

- What I did
Download the CLI for macOS and Linux as they are available on download.docker.com. This should make the build slightly faster.

Note the CLI is only used for testing – we do not ship it.

- How I did it
Replace build with curl.

- How to verify it
Existing tests should pass.

- Description for the changelog

N/A

- A picture of a cute animal (not mandatory)

@chris-crone chris-crone force-pushed the download-cli branch 2 times, most recently from 1effbfb to c2ed96b Compare November 8, 2019 09:16
Download the macOS and Linux Docker CLI from download.docker.com
instead of building them.

Signed-off-by: Christopher Crone <christopher.crone@docker.com>
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #730 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #730     +/-   ##
=========================================
- Coverage   70.57%   70.48%   -0.1%     
=========================================
  Files          62       62             
  Lines        3208     3208             
=========================================
- Hits         2264     2261      -3     
- Misses        639      641      +2     
- Partials      305      306      +1
Impacted Files Coverage Δ
types/parameters/parameters.go 92.06% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44932b6...88fcef1. Read the comment docs.

@rumpl rumpl merged commit 080e680 into docker:master Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants