This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Make flag cnab-bunle-json experimental #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's draft because the test fails and I'm waiting for #721 to be merged |
rumpl
force-pushed
the
feat-bundle-json-experimental
branch
from
3c6666a
to
a49c4e0
Compare
rumpl
force-pushed
the
feat-bundle-json-experimental
branch
2 times, most recently
from
1524e17
to
17110f9
Compare
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feat-bundle-json-experimental
branch
from
17110f9
to
9035402
Compare
eunomie
approved these changes
Nov 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
- Coverage 69.72% 69.29% -0.44%
==========================================
Files 64 63 -1
Lines 3495 3397 -98
==========================================
- Hits 2437 2354 -83
+ Misses 738 733 -5
+ Partials 320 310 -10
Continue to review full report at Codecov.
|
ndeloof
reviewed
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Once app is GA and no longer hidden experimental we will want to hide
the cnab-bundle-json flag if the user didn't activate experimental
features. docker/cli was updated to latest that had the fix for cli
plugins to be able to get the client configuration (docker/cli#2095)
- How to verify it
Can't really verify it for now, nor can I write a test for this...
- A picture of a cute animal (not mandatory)
