Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

PR followup for add creation to bundles #739

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

zappy-shu
Copy link
Contributor

- What I did

Set custom payload version to current version number.
Cleaned up app image ls tests.

- How I did it

Set the custom payload version to DockerAppCustomVersionCurrent when creating a new bundle so as to reduce the number of required changes when developing a new version of the custom payload.

Cleaned up app image ls tests to remove:

  • Debug messages.
  • No longer necessary distinct vs total count test for image ls --quiet. Addition of the creation date to the bundle ensures that the image ID will always be unique.

- How to verify it

There are no functional changes so the CI tests should cover the verification.

- A picture of a cute animal (not mandatory)
kitten-2019-11-12

Cleaned up app image ls tests to remove:
- Debug messages
- No longer necessary distinct vs total count test for `image ls
--quiet`. Addition of the creation date to the bundle ensures that the
image ID will always be unique.

Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Set the custom payload version to `DockerAppCustomVersionCurrent` when
creating a new bundle so as to reduce the number of required changes
when developing a new version of the custom payload.

Signed-off-by: Nick Adcock <nick.adcock@docker.com>
@zappy-shu zappy-shu changed the title Add creation to bundles PR followup for add creation to bundles Nov 13, 2019
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #739 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #739   +/-   ##
=======================================
  Coverage   68.85%   68.85%           
=======================================
  Files          64       64           
  Lines        3432     3432           
=======================================
  Hits         2363     2363           
  Misses        750      750           
  Partials      319      319

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e61a8...d324765. Read the comment docs.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit b0bb564 into docker:master Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants