This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Add a seed for better randomness #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the seed the rand.Intn will always start from the same place and return the same application name Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
|
Please do not use |
The call to |
|
This is for random name generation |
|
Hmm, I thought I had fixed that one too, ok will change it there. |
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
=======================================
Coverage 68.98% 68.98%
=======================================
Files 64 64
Lines 3437 3437
=======================================
Hits 2371 2371
Misses 748 748
Partials 318 318Continue to review full report at Codecov.
|
|
Its ok to merge this though, before I change the implementation. |
ndeloof
approved these changes
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a call to
rand.SeedWithout the seed the rand.Intn will always start from the same place and
return the same application name
- How to verify it
Without this change run:
The second one would fail with a message:
Installation "gallant_poitras" already exists, use 'docker app update' instead- A picture of a cute animal (not mandatory)
