This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Support format option in docker app ls #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using either plain JSON or a go template Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
rumpl
approved these changes
Nov 13, 2019
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
=======================================
Coverage 70.81% 70.81%
=======================================
Files 64 64
Lines 3663 3663
=======================================
Hits 2594 2594
Misses 748 748
Partials 321 321Continue to review full report at Codecov.
|
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
rumpl
approved these changes
Nov 14, 2019
|
Could we add a test for this? |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
template
branch
4 times, most recently
from
9da966a
to
f723638
Compare
eunomie
reviewed
Nov 20, 2019
| default: | ||
| return defaultImageTableFormat | ||
| } | ||
| } |
There was a problem hiding this comment.
I should have written it like:
if source == formatter.TableFormatKey {
if quiet {
return formatter.DefaultQuietFormat
}
if digest {
return defaultImageTableFormatWithDigest
}
return defaultImageTableFormat
}I don't see the usage of switch with only one case and switch on different variables.
There was a problem hiding this comment.
Because this code was a (simplified) version of the original formatter from docker/cli. Wanted to keep implementations in sync
| type imageContext struct { | ||
| formatter.HeaderContext | ||
| trunc bool | ||
| i imageDesc |
There was a problem hiding this comment.
Why not ?
Suggested change
| i imageDesc | |
| image imageDesc |
ndeloof
force-pushed
the
template
branch
2 times, most recently
from
d30c6d7
to
cc7360f
Compare
set by cli/command/formatter/formatter.go#postFromat Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Introduced
--formatexperimental option fordocker app lsCan either pass a Go template (jist like most docker CLI commands) or just "json" to enable json output.
- How I did it
with love
- How to verify it
docker app ls --format "{{(index . 0).Reference}}"
docker app ls --format "json"
- Description for the changelog
Introduced
--formatexperimental option fordocker app ls- A picture of a cute animal (not mandatory)
