Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

My PR was merged #749

Merged
merged 1 commit into from
Nov 18, 2019
Merged

My PR was merged #749

merged 1 commit into from
Nov 18, 2019

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 18, 2019

- What I did
Stop using a fork and switch to upstream repo

- How I did it
dep

- How to verify it
I didn't breack the build :)
(this is an e2e test dependency)

- Description for the changelog

- A picture of a cute animal (not mandatory)
image

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eunomie eunomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have a more clear commit message?

My PR was merged

says nothing about the PR, the need, etc.
Maybe we can at least link the PR?

@ndeloof
Copy link
Contributor Author

ndeloof commented Nov 18, 2019

The change here is to stop using a fork, not introducing dependency which would legitimately require to explain why it is introduced
The explanation you're asking for is here 8beb2f1

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #749 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   68.59%   68.59%           
=======================================
  Files          63       63           
  Lines        3477     3477           
=======================================
  Hits         2385     2385           
  Misses        775      775           
  Partials      317      317

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a57a93e...05a8a01. Read the comment docs.

jackpal/gateway#21

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@eunomie eunomie merged commit 0249717 into docker:master Nov 18, 2019
@ndeloof ndeloof deleted the gateway branch November 18, 2019 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants