Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Fix output to have a consistent naming #750

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

carolinebriaud
Copy link
Contributor

@carolinebriaud carolinebriaud commented Nov 18, 2019

Signed-off-by: Caroline Briaud caroline.briaud@docker.com

- What I did
Fix output in docker app image ls and docker app inspect to have a consistent naming
Fix link issue in examples/README.MD

- How to verify it
Run docker app image ls and docker app inspect commands and check outputs
Check link in examples/README.MD

- A picture of a cute animal (not mandatory)
hedgehog-468228_1920

@@ -137,7 +137,7 @@ Next, you can check the list of running Apps:

```shell
$ docker app ls
INSTALLATION APPLICATION LAST ACTION RESULT CREATED MODIFIED REFERENCE
RUNNING APP APP NAME LAST ACTION RESULT CREATED MODIFIED REFERENCE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if APP NAME should become APP IMAGE at some point

Copy link
Contributor Author

@carolinebriaud carolinebriaud Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is actually the app name coming from the metadata, so really this has nothing to do with the name you give to the app image when you build

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unclear to me what this metadata name is for. I can't imagine much scenario where it's anything else but the repository name image is published to.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…nsistent naming

Signed-off-by: Caroline Briaud <caroline.briaud@docker.com>
@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   68.94%   68.94%           
=======================================
  Files          63       63           
  Lines        3446     3446           
=======================================
  Hits         2376     2376           
  Misses        753      753           
  Partials      317      317

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0249717...3c61975. Read the comment docs.

@carolinebriaud carolinebriaud merged commit a04e9b3 into docker:master Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants