Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Remove extra flags on docker app inspect command #751

Merged

Conversation

silvin-lubecki
Copy link
Contributor

- What I did
orchestrator and namespace flags are not needed, as they are parameters stored in the claim so we can retrieve them. The user shouldn't be allowed to override them.

Also removed default orchestrator code for inspect, as orchestrator is not mandatory for every bundles (some bundles may just run on a single engine).

- Description for the changelog

  • Removed orchestrator and namespace flags for docker app inspect command

- A picture of a cute animal (not mandatory)
image

…rs stored in the claim so we can retrieve them. The user shouldn't be allowed to override them.

Also removed default orchestrator code for inspect, as orchestrator is not mandatory for every bundles (some bundles may just run on a single engine).

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #751 into master will increase coverage by 0.65%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   68.59%   69.25%   +0.65%     
==========================================
  Files          63       63              
  Lines        3477     3428      -49     
==========================================
- Hits         2385     2374      -11     
+ Misses        775      738      -37     
+ Partials      317      316       -1
Impacted Files Coverage Δ
internal/commands/inspect.go 17.46% <0%> (+1.21%) ⬆️
internal/inspect/inspect.go 89.2% <85.71%> (+0.5%) ⬆️
internal/commands/push.go 33.58% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0249717...fb411ac. Read the comment docs.

@silvin-lubecki silvin-lubecki merged commit 6c2b173 into docker:master Nov 19, 2019
@silvin-lubecki silvin-lubecki deleted the remove-useless-inspect-flags branch November 19, 2019 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants