This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Update CNAB-simple example to reflect the UX changes #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinebriaud
force-pushed
the
fix-example-next
branch
from
c46eab6
to
2665b97
Compare
Signed-off-by: Caroline Briaud <caroline.briaud@docker.com>
carolinebriaud
force-pushed
the
fix-example-next
branch
from
2665b97
to
0c682c3
Compare
carolinebriaud
force-pushed
the
fix-example-next
branch
from
7b2ffdb
to
f4c7d5d
Compare
Add final step (remove running app) to hello-world example. Signed-off-by: Caroline Briaud <caroline.briaud@docker.com>
carolinebriaud
force-pushed
the
fix-example-next
branch
from
f4c7d5d
to
ede60f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
=========================================
- Coverage 69.35% 69.25% -0.1%
=========================================
Files 63 63
Lines 3462 3428 -34
=========================================
- Hits 2401 2374 -27
+ Misses 742 738 -4
+ Partials 319 316 -3
Continue to review full report at Codecov.
|
rumpl
approved these changes
Nov 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Caroline Briaud caroline.briaud@docker.com
- What I did
Update CNAB-simple example to reflect the UX changes.
Add final step (remove running app) to hello-world example.
- How to verify it
Check the README file
- A picture of a cute animal (not mandatory)
