This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
[APP-257] Add integration tests to check CNAB bundle API #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiordache
requested review from
chris-crone and
silvin-lubecki
as code owners
|
Please sign your commits following these rules: $ git clone -b "app-257_cnab_api_tests" git@github.com:aiordache/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354111120
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
aiordache
force-pushed
the
app-257_cnab_api_tests
branch
from
a4d8af5
to
d20c5c8
Compare
aiordache
changed the title
aiordache
force-pushed
the
app-257_cnab_api_tests
branch
from
7277e85
to
f6e4aec
Compare
aiordache
force-pushed
the
app-257_cnab_api_tests
branch
from
bf747a1
to
78a0f26
Compare
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
+ Coverage 70.17% 70.26% +0.08%
==========================================
Files 64 64
Lines 3568 3598 +30
==========================================
+ Hits 2504 2528 +24
- Misses 732 735 +3
- Partials 332 335 +3
Continue to review full report at Codecov.
|
aiordache
changed the title
aiordache
force-pushed
the
app-257_cnab_api_tests
branch
3 times, most recently
from
bb5a553
to
92a76c7
Compare
aiordache
force-pushed
the
app-257_cnab_api_tests
branch
2 times, most recently
from
f08376e
to
8d96f98
Compare
rumpl
reviewed
Nov 26, 2019
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
aiordache
force-pushed
the
app-257_cnab_api_tests
branch
from
8d96f98
to
f1e3cee
Compare
aiordache
force-pushed
the
app-257_cnab_api_tests
branch
from
59bcaf1
to
d3918d8
Compare
eunomie
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
Looks good as a first version if @silvin-lubecki is ok with the answers to his comments.
e2e/compatibility_test.go
Outdated
| ) | ||
|
|
||
| func loadAndTagImage(info dindSwarmAndRegistryInfo, tmpDir *fs.Dir, tag string, url string) error { | ||
|
|
| assert.NilError(t, os.MkdirAll(bundleDir, os.FileMode(0777))) | ||
| assert.NilError(t, ioutil.WriteFile(filepath.Join(bundleDir, "bundle.json"), data, os.FileMode(0644))) | ||
|
|
||
| // load images build with an old Docker App version |
There was a problem hiding this comment.
Suggested change
| // load images build with an old Docker App version | |
| // load images built with an old Docker App version |
silvin-lubecki
approved these changes
Nov 27, 2019
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APP-257
- What I did
Check mandatory fields in the CNAB bundle for v1.
Added E2E test for running an app generated with an old docker app version.
- Description for the changelog
E2E test for backwards compatibility
- A picture of a cute animal (not mandatory)