This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Sort app image ls by created #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zappy-shu
changed the title
zappy-shu
force-pushed
the
APP-344-sort-images-by-creat-date
branch
2 times, most recently
from
a8967cb
to
acc00b1
Compare
zappy-shu
changed the title
Sorts apps by created date (if available) when running `app image ls` with the latest created apps coming first. Signed-off-by: Nick Adcock <nick.adcock@docker.com>
zappy-shu
force-pushed
the
APP-344-sort-images-by-creat-date
branch
from
acc00b1
to
0a3e85a
Compare
rumpl
approved these changes
Nov 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Sorts apps by created date (if available) when running
app image lswith the latest created apps coming first.- How I did it
Before printing the images they are first sorted by checking the custom payload. If the bundles contain a docker custom payload that has a creation date then this is used to sort them. If only one bundle has a creation date then it is considered the newer one. A stable sort is used so that non-App bundles and tags do not get muddled.
- How to verify it
Build multiple App images. Run
docker app image ls. The result should order the images by creation date.- Description for the changelog
App images are sorted by creation date with the newest first when running
app image ls- A picture of a cute animal (not mandatory)