This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Update dockercoins README to match new UX #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinebriaud
force-pushed
the
fix-coins
branch
2 times, most recently
from
536183c
to
24eb67f
Compare
eunomie
reviewed
Nov 22, 2019
examples/dockercoins/README.md
Outdated
| Now we are going to build an App image from this App definition. At build time, Docker App is going to build each service image then build the App image embedding the service images. | ||
|
|
||
| ```shell | ||
| $ docker app build . -f coins.dockerapp -t myrepo/coins:0.1.0 |
There was a problem hiding this comment.
Suggested change
| $ docker app build . -f coins.dockerapp -t myrepo/coins:0.1.0 | |
| $ docker app build -f coins.dockerapp -t myrepo/coins:0.1.0 . |
Just to match the documentation of docker app build command
There was a problem hiding this comment.
Thank you! Done.
Signed-off-by: Caroline Briaud <caroline.briaud@docker.com>
carolinebriaud
force-pushed
the
fix-coins
branch
from
24eb67f
to
578c58b
Compare
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
=========================================
- Coverage 70.07% 69.5% -0.57%
=========================================
Files 64 64
Lines 3519 3519
=========================================
- Hits 2466 2446 -20
- Misses 727 753 +26
+ Partials 326 320 -6
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Caroline Briaud caroline.briaud@docker.com
- What I did
Update dockercoins README to match new UX
- How to verify it
Check the README
- A picture of a cute animal (not mandatory)
