This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Standardize column spacing in output #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardizes the column spacing when writing tables to the output to have the same width and padding as with standard docker CLI commands Includes both Docker App and invocation image outputs Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #774 +/- ##
=======================================
Coverage 70.44% 70.44%
=======================================
Files 67 67
Lines 3729 3729
=======================================
Hits 2627 2627
Misses 758 758
Partials 344 344Continue to review full report at Codecov.
|
ndeloof
approved these changes
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Standardizes the column spacing when writing tables to the output to have the same width and padding as with standard docker CLI commands
Includes both Docker App and invocation image outputs
- How I did it
Updated creation of tab writers to all have a min spacing of 20 and padding of 3.
- How to verify it
Run
docker app inspect my-app --pretty. The tables below the metadata should have the new spacing.- Description for the changelog
Outputs printed as tables from Docker App commands now have standard spacing
- A picture of a cute animal (not mandatory)