Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Add -f shorthand to app rm --force #776

Merged

Conversation

zappy-shu
Copy link
Contributor

- What I did

Makes -f the shorthand for --force in docker app rm, same as in docker rm and docker app image rm

- How I did it

Use BoolVarP for the force option

- How to verify it

Run docker app rm --help The output should show -f as an alias for --force like so:

Options:
      --credential stringArray       Add a single credential, additive ontop of any --credential-set used
      --credential-set stringArray   Use a YAML file containing a credential set or a credential set present in the credential store
  -f, --force                        Force the removal of a running App
      --with-registry-auth           Sends registry auth

- Description for the changelog

Add -f shorthand to app rm --force

- A picture of a cute animal (not mandatory)

weasel-2019-12-02

Makes -f the shorthand for --force in `docker app rm`, same as in `docker rm` and `docker app image rm`

Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #776 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #776   +/-   ##
=======================================
  Coverage   70.44%   70.44%           
=======================================
  Files          67       67           
  Lines        3729     3729           
=======================================
  Hits         2627     2627           
  Misses        758      758           
  Partials      344      344
Impacted Files Coverage Δ
internal/commands/remove.go 50.94% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d119541...3cebbc2. Read the comment docs.

@zappy-shu zappy-shu merged commit d198096 into docker:master Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants