This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Remove CREATED from bundle.json #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the created date from the bundle.json and the image ls output This has been done to make builds more reproducable as the current solution means the App Image ID will change on each build We will look at re-adding the created date once the underlying bundle store has been updated. Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 71.82% 70.33% -1.49%
==========================================
Files 67 67
Lines 3858 3712 -146
==========================================
- Hits 2771 2611 -160
- Misses 739 757 +18
+ Partials 348 344 -4
Continue to review full report at Codecov.
|
zappy-shu
changed the title
zappy-shu
changed the title
zappy-shu
changed the title
ndeloof
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Removes the created date from the bundle.json and the image ls output
This has been done to make builds more reproducable as the current solution means the App Image ID will change on each build
We will look at re-adding the created date once the underlying bundle store has been updated.
- How to verify it
Build a Docker App and:
docker app image ls: there should no longer be a CREATED column.bundle.json: there should be nocustom:com.docker.app:payload:createdproperty.- Description for the changelog
Removes custom created date from Docker App bundle.json so as to make builds more repeatable.
- A picture of a cute animal (not mandatory)