Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix workflow dispatch inputs #672

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

crazy-max
Copy link
Member

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested review from tonistiigi and jedevc August 17, 2022 09:06
Copy link
Contributor

@jedevc jedevc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me :)

I'm confused, did this just not work before at all? It looks like matrix doesn't have a buildx-version property, so did this just get silently omitted?

@crazy-max
Copy link
Member Author

I'm confused, did this just not work before at all? It looks like matrix doesn't have a buildx-version property, so did this just get silently omitted?

Yes silently omitted even if there is no matrix available 😞

@crazy-max crazy-max merged commit 965c6a4 into docker:master Aug 17, 2022
@crazy-max crazy-max deleted the fix-ci-dispatch branch August 17, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants