Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect: display proxy config #1864

Closed
wants to merge 1 commit into from

Conversation

crazy-max
Copy link
Member

related to docker/build-push-action#872 where I wanted to set proxy envs through docker config but could not see if it was set without this change: https://github.com/docker/build-push-action/actions/runs/5175036309/jobs/9322112341#step:6:136

  /usr/bin/docker buildx inspect --bootstrap --builder builder-bd6fd9e2-bff4-4452-89fc-c77bdad3af8c
  #1 [internal] booting buildkit
  #1 pulling image moby/buildkit:buildx-stable-1 0.1s done
  #1 creating container buildx_buildkit_builder-bd6fd9e2-bff4-4452-89fc-c77bdad3af8c0
  #1 creating container buildx_buildkit_builder-bd6fd9e2-bff4-4452-89fc-c77bdad3af8c0 0.5s done
  #1 DONE 0.7s
  Name:          builder-bd6fd9e2-bff4-4452-89fc-c77bdad3af8c
  Driver:        docker-container
  Last Activity: 2023-06-05 08:36:32 +0000 UTC
  
  Nodes:
  Name:           builder-bd6fd9e2-bff4-4452-89fc-c77bdad3af8c0
  Endpoint:       unix:///var/run/docker.sock
  Driver Options: image="moby/buildkit:buildx-stable-1"
  Status:         running
  Flags:          --debug
  Buildkit:       v0.11.6
  Platforms:      linux/amd64, linux/amd64/v2, linux/amd64/v3, linux/amd64/v4, linux/386
  Labels:
   org.mobyproject.buildkit.worker.executor:         oci
   org.mobyproject.buildkit.worker.hostname:         736e3a301e01
   org.mobyproject.buildkit.worker.network:          host
   org.mobyproject.buildkit.worker.oci.process-mode: sandbox
   org.mobyproject.buildkit.worker.selinux.enabled:  false
   org.mobyproject.buildkit.worker.snapshotter:      overlayfs
  Proxy config:
   HTTPS_PROXY: http://localhost:3128
   HTTP_PROXY:  http://localhost:3128
  GC Policy rule#0:
   All:           false
   Filters:       type==source.local,type==exec.cachemount,type==source.git.checkout
   Keep Duration: 48h0m0s
   Keep Bytes:    488.3MiB
  GC Policy rule#1:
   All:           false
   Keep Duration: 1440h0m0s
   Keep Bytes:    8.382GiB
  GC Policy rule#2:
   All:        false
   Keep Bytes: 8.382GiB
  GC Policy rule#3:
   All:        true
   Keep Bytes: 8.382GiB

@crazy-max crazy-max requested a review from jedevc June 6, 2023 13:29
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the inspect-proxy-config branch from a088c6b to 35d1787 Compare June 6, 2023 15:55
@crazy-max crazy-max requested a review from tonistiigi June 6, 2023 16:58
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the usefulness of showing these values, but iiuc these are not builder/node specific but loaded from local docker CLI config. Therefore it is misleading to show them here (or at least should be in a separate global section). Another alternative would be to print it directly in actions.

@crazy-max crazy-max marked this pull request as draft June 6, 2023 17:22
@crazy-max crazy-max closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants