Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump containerd/console to use console.File instead of os.File #203

Closed
wants to merge 0 commits into from

Conversation

ulyssessouza
Copy link
Contributor

This PR just changes the signature of NewPrinter to use console.File instead of os.File to allow other structs to be passed.
Check docker/app#779

@tonistiigi
Copy link
Member

@ulyssessouza CI doesn't seem to like it. Did you run make vendor to update vendor in containers?

@ulyssessouza
Copy link
Contributor Author

@tonistiigi I just did a go mod vendor. I've just pushed it again after the make vendor

@tonistiigi
Copy link
Member

@ulyssessouza Seems new sys broke windows build:

#56 376.6 vendor/github.com/docker/docker/pkg/system/filesys_windows.go:111:24: cannot use uintptr(unsafe.Pointer(&sd[0])) (type uintptr) as type *"golang.org/x/sys/windows".SECURITY_DESCRIPTOR in assignment

@tonistiigi
Copy link
Member

tonistiigi commented Dec 10, 2019

That change seems to be done in moby already, just docker/docker dependency needs to be updated as well. Keep the v1.14.0-0 prefix for it until we figure out some better solution.

@tonistiigi
Copy link
Member

@ulyssessouza Not sure if you're still working on it but that doesn't seem to be the correct version. Looks like docker was actually downgraded in your last push.

@ulyssessouza
Copy link
Contributor Author

@tonistiigi I don't know why, but github just closed the PR and didn't want to reopen, so I created another one #207 .
Sorry for that :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants