-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: set record status in response #2511
Conversation
705b3f3
to
aafd62e
Compare
aafd62e
to
4353850
Compare
064c8cb
to
128579d
Compare
8e001be
to
9fce297
Compare
Opened docker/actions-toolkit#362 as follow-up to consume this in our GitHub actions. Edit: Also docker/actions-toolkit#365 to annotate checks. |
9fce297
to
e759a1b
Compare
@tonistiigi Updated to make it opt-in instead. |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
e759a1b
to
415f88f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I did not mean combining/replacing this with provenance opt-in when we discussed it. I meant adding another opt-in, similar to what we did with provenance.
return nil | ||
} | ||
pw = progress.ResetTime(pw) | ||
return progress.Wrap("resolving status for metadata file", pw.Write, func(l progress.SubLogger) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be pulled via history API and new progress item added. You can get the warnings by calling printer.Warnings()
from command packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #2551 as alternative
replaced by #2551 ? |
Similar to #2280, we can set build checks warnings in the metadata file. Does not set anything by default but can be customized using the
BUILDX_METADATA_STATUS
environment variable to set just warnings or full status.This will be useful with our GitHub Actions so we can generate GitHub Annotations without having to do a subrequest build like in https://github.com/crazy-max/docker-build-push-action/pull/39/files#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3dR132
Output example in e2e workflow: https://github.com/docker/buildx/actions/runs/9498949574/job/26178830826#step:9:201
# syntax=docker/dockerfile-upstream:master frOM busybox as base cOpy Dockerfile . from scratch COPy --from=base \ /Dockerfile \ /