Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message when --check does not produce warnings or errors #2549

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

daghack
Copy link
Contributor

@daghack daghack commented Jun 24, 2024

Currently, in the case that --check produces no errors or warnings, there is no output to clarify this. This adds a simple user facing message in the case to indicate such when it occurs.

~/example$ BUILDX_EXPERIMENTAL=1 docker --debug buildx --builder=dev build --check .
[+] Building 0.1s (3/3) FINISHED                                                                                                         docker-container:dev
 => [internal] connecting to local controller                                                                                                            0.0s
 => [internal] load build definition from Dockerfile                                                                                                     0.0s
 => => transferring dockerfile: 105B                                                                                                                     0.0s
 => [internal] load .dockerignore                                                                                                                        0.0s
 => => transferring context: 2B                                                                                                                          0.0s

Becomes

~/example$ BUILDX_EXPERIMENTAL=1 docker --debug buildx --builder=dev build --check .
[+] Building 0.2s (3/3) FINISHED                                                                                                         docker-container:dev
=> [internal] connecting to local controller                                                                                                            0.0s
=> [internal] load build definition from Dockerfile                                                                                                     0.0s
=> => transferring dockerfile: 105B                                                                                                                     0.0s
=> [internal] load .dockerignore                                                                                                                        0.0s
=> => transferring context: 2B                                                                                                                          0.0s
Check complete, no warnings found.

@daghack daghack self-assigned this Jun 24, 2024
@daghack daghack modified the milestone: v0.15.2 Jun 24, 2024
@daghack daghack added the kind/enhancement New feature or request label Jun 24, 2024
@daghack daghack requested a review from tonistiigi June 24, 2024 05:01
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be printed if format is json. Same for the newline in the Error formatter.

Signed-off-by: Talon Bowler <talon.bowler@docker.com>
@tonistiigi tonistiigi merged commit 2b17f27 into docker:master Jun 28, 2024
103 checks passed
@daghack daghack deleted the warning-free-msg branch July 1, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants