Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

driver: allow arbitrary client opts #2578

Merged
merged 1 commit into from
Jul 10, 2024
Merged

driver: allow arbitrary client opts #2578

merged 1 commit into from
Jul 10, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 4, 2024 •
edited
Loading

cc @fiam

@crazy-max crazy-max changed the title driver: add variadic client opt to Client driver: allow arbitrary client opts Jul 4, 2024
@crazy-max crazy-max added this to the v0.16.0 milestone Jul 4, 2024
@crazy-max crazy-max requested a review from tonistiigi July 4, 2024 09:50
@crazy-max crazy-max marked this pull request as ready for review July 4, 2024 09:50
@crazy-max
driver: allow arbitrary client opts
1dceb49 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
tonistiigi
tonistiigi reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this actually works because the client is cached. The options would only matter for the very first call.

@tonistiigi tonistiigi merged commit ee642ec into docker:master Jul 10, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees

@tonistiigi tonistiigi

Labels
area/builder area/driver
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@crazy-max @tonistiigi