Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ls and inspect timeouts #323

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Conversation

saulshanabrook
Copy link
Contributor

@saulshanabrook saulshanabrook commented Jul 16, 2020

I was getting a listing workers: failed to list workers: rpc error: code = DeadlineExceeded desc = context deadline exceeded error when running docker buildx ls and docker buildx inspect with the Kubernetes driver, some of the time:

$ docker buildx inspect
Name:   cool_fermi
Driver: kubernetes

Nodes:
Name:     buildx0-6dcb5544c6-457mv
Endpoint:
Error:    listing workers: failed to list workers: rpc error: code = DeadlineExceeded desc = context deadline exceeded

$ docker buildx ls
NAME/NODE                  DRIVER/ENDPOINT STATUS PLATFORMS
cool_fermi *               kubernetes
  buildx0-6dcb5544c6-457mv                 listing workers: failed to list workers: rpc error: code = DeadlineExceeded desc = context deadline exceeded
default                    docker
  default                  default         running linux/amd64, linux/arm64, linux/ppc64le, linux/s390x, linux/386, linux/arm/v7, linux/arm/v6

I was able to resolve this by increasing the context timeout of both commands from 5 and 7 seconds to 20 seconds. This might be because I am on a satellite internet connection with higher latency to the Kubernetes cluster in the cloud.

Signed-off-by: Saul Shanabrook <s.shanabrook@gmail.com>
Signed-off-by: Saul Shanabrook <s.shanabrook@gmail.com>
@tonistiigi
Copy link
Member

@AkihiroSuda is this same as #315 ?

Maybe we should make these configurable. 20 sec might be ok but overall this makes the experience worse for the cases where instances never connect.

Another approach might be to try to see if it is in the middle of connecting already. Only cancel with timeout it there was no response at all.

@tonistiigi tonistiigi merged commit 9ac5b07 into docker:master Aug 21, 2020
@tonistiigi
Copy link
Member

Created issue for follow-up #358

@saulshanabrook
Copy link
Contributor Author

Ah sorry I didn't see your comment. Yeah, making it configurable seems good.

@saulshanabrook saulshanabrook deleted the patch-1 branch August 22, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants